Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 137593005: IDL compiler: [RaisesException] for non-void methods (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)
Modified:
6 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

IDL compiler: [RaisesException] for non-void methods Other case, caught while checking test cases. (Most [RaisesException] methods are void, but not all.) BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165022

Patch Set 1 #

Patch Set 2 : Tweak #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M Source/bindings/scripts/unstable/v8_methods.py View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
6 years, 11 months ago (2014-01-14 03:01:21 UTC) #1
haraken
LGTM
6 years, 11 months ago (2014-01-14 03:37:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/137593005/7
6 years, 11 months ago (2014-01-14 03:49:53 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 04:06:58 UTC) #4
Message was sent while issue was closed.
Change committed as 165022

Powered by Google App Engine
This is Rietveld 408576698