Source/bindings/templates/methods.cpp - Issue 137593005: IDL compiler: [RaisesException] for non-void methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 137593005: IDL compiler: [RaisesException] for non-void methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index a8afb3f016d80cbb5ad95c8b0b87f2992fea194e..337593cf282b727850f690f87723e452c094177e 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -177,7 +177,7 @@ RefPtr<ScriptArguments> scriptArguments(createScriptArguments(info, {{method.num

{% endif %}

{% if method.idl_type == 'void' %}

{{cpp_value}};

-{% elif method.is_call_with_script_state %}

+{% elif method.is_call_with_script_state or method.is_raises_exception %}

{# FIXME: consider always using a local variable #}

{{method.cpp_type}} result = {{cpp_value}};

{% endif %}