Issue 1375923002: [turbofan] Remove obsolete helpers from graph verifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1375923002: [turbofan] Remove obsolete helpers from graph verifier. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger

Modified:
5 years, 2 months ago

Reviewers:
Jarin

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Remove obsolete helpers from graph verifier. The NodeProperties helpers are here to stay and won't go away anytime soon. This removes a TODO from the graph verifier in that regard. R=jarin@chromium.org Committed: https://crrev.com/1d03fc17b40aa1d7bd8a89991a25859917870fb0 Cr-Commit-Position: refs/heads/master@{#31007}

Patch Set 1 #

Patch Set 2 : One more #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	src/compiler/verifier.cc	View	1	4 chunks	+10 lines, -14 lines	0 comments	Download

Dependent Patchsets:

Issue 1379593002 Patch 1

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375923002/20001

5 years, 2 months ago (2015-09-29 14:33:58 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-09-29 14:43:00 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/1d03fc17b40aa1d7bd8a89991a25859917870fb0
Cr-Commit-Position: refs/heads/master@{#31007}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages