Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1379593002: [turbofan] Pass scope infos as static operator parameters. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-turbofan-verifier
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pass scope infos as static operator parameters. This changes the operators for JSCreate[Block|Script]Context to take their ScopeInfo as a static parameter as opposed to a value input and in turn allows for easier access to that parameter during lowerings. R=jarin@chromium.org Committed: https://crrev.com/8dfe18559c730e22d02be77993a775a250178227 Cr-Commit-Position: refs/heads/master@{#31009}

Patch Set 1 #

Patch Set 2 : Fix unit test. #

Patch Set 3 : Fix Windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -35 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 4 chunks +20 lines, -9 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +23 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/operator.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-29 14:38:18 UTC) #1
Jarin
lgtm (but the microsoft compiler seems to be of different opinion).
5 years, 2 months ago (2015-09-29 14:44:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379593002/40001
5 years, 2 months ago (2015-09-29 15:51:22 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-29 15:53:15 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 15:53:40 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8dfe18559c730e22d02be77993a775a250178227
Cr-Commit-Position: refs/heads/master@{#31009}

Powered by Google App Engine
This is Rietveld 408576698