components/password_manager/core/browser/affiliated_match_helper.h - Issue 1375883002: Support Android username-only credentials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliated_match_helper.h

Issue 1375883002: Support Android username-only credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/affiliated_match_helper.h

diff --git a/components/password_manager/core/browser/affiliated_match_helper.h b/components/password_manager/core/browser/affiliated_match_helper.h

index 18cb0d5cd4f0cb621d0ff41732a4749d6738019a..659dbc52539b0bcd8c09222644112224d00d4810 100644

--- a/components/password_manager/core/browser/affiliated_match_helper.h

+++ b/components/password_manager/core/browser/affiliated_match_helper.h

@@ -93,7 +93,7 @@ class AffiliatedMatchHelper : public PasswordStore::Observer,

// Consumes a list of |android_credentials| corresponding to applications that

// are affiliated with the realm of |observed_form|, and transforms them so

// as to make them fillable into |observed_form|. This can be called from any

- // thread.

+ // thread. Non-federated username-only credentials are filtered.

Mike West 2015/09/29 09:36:09 Why only "non-federated"?

vasilii 2015/10/12 15:12:48 Done.

static ScopedVector<autofill::PasswordForm>

TransformAffiliatedAndroidCredentials(

const autofill::PasswordForm& observed_form,