Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 1375883002: Support Android username-only credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/core/common/password_form.h ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/affiliated_match_helper.h » ('j') | components/password_manager/core/browser/affiliated_match_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/save_password_progress_logger.cc
diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc
index c7c51ccceb56cfed3cfa274b271db37b07d9b084..7c7240a7ceb3bd56115452218756f93c14d4a80f 100644
--- a/components/autofill/core/common/save_password_progress_logger.cc
+++ b/components/autofill/core/common/save_password_progress_logger.cc
@@ -57,6 +57,8 @@ SavePasswordProgressLogger::StringID FormSchemeToStringID(
return SavePasswordProgressLogger::STRING_SCHEME_DIGEST;
case PasswordForm::SCHEME_OTHER:
return SavePasswordProgressLogger::STRING_OTHER;
+ case PasswordForm::SCHEME_USERNAME_ONLY:
+ return SavePasswordProgressLogger::STRING_SCHEME_USERNAME_ONLY;
}
NOTREACHED();
return SavePasswordProgressLogger::STRING_INVALID;
@@ -180,6 +182,8 @@ std::string SavePasswordProgressLogger::GetStringFromID(
return "Basic";
case SavePasswordProgressLogger::STRING_SCHEME_DIGEST:
return "Digest";
+ case SavePasswordProgressLogger::STRING_SCHEME_USERNAME_ONLY:
+ return "Android username only";
Mike West 2015/09/29 09:36:09 How about "username only", so we can be happy in a
engedy 2015/10/08 17:31:01 +1.
vasilii 2015/10/12 15:12:48 Done.
case SavePasswordProgressLogger::STRING_SCHEME_MESSAGE:
return "Scheme";
case SavePasswordProgressLogger::STRING_SIGNON_REALM:
« components/autofill/core/common/password_form.h ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/affiliated_match_helper.h » ('j') | components/password_manager/core/browser/affiliated_match_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698