Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1375643002: [tracing] directly use memory-infra from blink -> base (Closed)

Created:
5 years, 2 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] directly use memory-infra from blink -> base Now that the blink repo has been merged there isn't any reason to keep the memory-infra glue layer around. This CL makes direct use of the few /base/trace_event/ headers for memory-infra from blink: - base/trace_event/memory_allocator_dump.h - base/trace_event/memory_dump_provider.h - base/trace_event/process_memory_dump.h A follow-up CL (crrev.com/1394183003) will take care of removing the useless glue layer classes. This CL depends on crrev.com/1382583002 for the wtf::String toUTF8StdString() method. BUG=541262

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -60 lines) Patch
M base/trace_event/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/memory_dump_provider.h View 1 2 chunks +20 lines, -0 lines 1 comment Download
A base/trace_event/memory_dump_provider.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp View 1 6 chunks +16 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h View 1 1 chunk +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 3 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 8 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
esprehn
typo in your patch title? :P https://codereview.chromium.org/1375643002/diff/20001/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp File third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp (right): https://codereview.chromium.org/1375643002/diff/20001/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp#newcode28 third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp:28: return std::string(reinterpret_cast<const char*>(str.ascii().data())); ...
5 years, 2 months ago (2015-09-28 18:03:14 UTC) #3
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1375643002/diff/20001/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp File third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp (right): https://codereview.chromium.org/1375643002/diff/20001/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp#newcode28 third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp:28: return std::string(reinterpret_cast<const char*>(str.ascii().data())); On 2015/09/28 18:03:14, esprehn wrote: > ...
5 years, 2 months ago (2015-09-28 19:07:40 UTC) #4
Primiano Tucci (use gerrit)
Ok, there is a lot of cleanup we can do here. The actual deletion happens ...
5 years, 2 months ago (2015-10-08 18:16:26 UTC) #7
Ruud van Asseldonk
https://codereview.chromium.org/1375643002/diff/60001/base/trace_event/memory_dump_provider.h File base/trace_event/memory_dump_provider.h (right): https://codereview.chromium.org/1375643002/diff/60001/base/trace_event/memory_dump_provider.h#newcode36 base/trace_event/memory_dump_provider.h:36: static void Register( Does this introduce two ways of ...
5 years, 2 months ago (2015-10-08 18:40:55 UTC) #8
Primiano Tucci (use gerrit)
5 years, 2 months ago (2015-10-09 09:25:19 UTC) #9
Given https://codereview.chromium.org/1382583002/ let's put this on hold until
blink owners don't figure out a plan.
We'll keep using the glue layer as usual until then.

On 2015/10/08 18:40:55, Ruud van Asseldonk wrote:
>
https://codereview.chromium.org/1375643002/diff/60001/base/trace_event/memory...
> File base/trace_event/memory_dump_provider.h (right):
> 
>
https://codereview.chromium.org/1375643002/diff/60001/base/trace_event/memory...
> base/trace_event/memory_dump_provider.h:36: static void Register(
> Does this introduce two ways of doing the same thing,
> |MemoryDumpProvider::Register(mdp)| vs
> |MemoryDumpManager::GetInstance()->RegisterDumpProvider(mdp)|? Why is that
> required?
This was to avoid including memory_dump_manager.h. Specifically its tracing
includes end up defining the same macros that are defined in the blink fork of
tracing.
All this will be solved once we properly get rid of all the tracing layers in
blink.

In the meantime, keep plumbing as usual

Powered by Google App Engine
This is Rietveld 408576698