third_party/WebKit/Source/platform/exported/Platform.cpp - Issue 1375643002: [tracing] directly use memory-infra from blink -> base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/Platform.cpp

Issue 1375643002: [tracing] directly use memory-infra from blink -> base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_dump_provider.h ('K') | « third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp ('k') | third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/Platform.cpp

diff --git a/third_party/WebKit/Source/platform/exported/Platform.cpp b/third_party/WebKit/Source/platform/exported/Platform.cpp

index 2b2ccb844556789f76c7a95a312bf5460fffa513..bd919266d0a61bc0fba3d7707b544725572b1690 100644

--- a/third_party/WebKit/Source/platform/exported/Platform.cpp

+++ b/third_party/WebKit/Source/platform/exported/Platform.cpp

@@ -49,13 +49,13 @@ void Platform::initialize(Platform* platform)

// TODO(ssid): remove this check after fixing crbug.com/486782.

if (s_platform && s_platform->m_mainThread)

- s_platform->registerMemoryDumpProvider(PartitionAllocMemoryDumpProvider::instance());

+ base::trace_event::MemoryDumpProvider::RegisterOnCurrentThread(PartitionAllocMemoryDumpProvider::instance());

}

void Platform::shutdown()

{

if (s_platform->m_mainThread)

- s_platform->unregisterMemoryDumpProvider(PartitionAllocMemoryDumpProvider::instance());

+ base::trace_event::MemoryDumpProvider::Unregister(PartitionAllocMemoryDumpProvider::instance());

if (s_platform)

s_platform->m_mainThread = 0;