Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

Issue 137563004: libaddressinput: Add fallback data for US address validation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix fmt Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
diff --git a/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc b/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
index e99e3e73a210ef829317fe45bb865bef80d49036..5e7cd26280f449e37e7b61dc13dccc20778a6494 100644
--- a/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
+++ b/third_party/libaddressinput/chromium/cpp/test/retriever_test.cc
@@ -122,6 +122,18 @@ TEST_F(RetrieverTest, FaultyDownloader) {
EXPECT_TRUE(data_.empty());
}
+TEST_F(RetrieverTest, FaultyDownloaderFallback) {
+ Retriever bad_retriever(FakeDownloader::kFakeDataUrl,
+ scoped_ptr<Downloader>(new FaultyDownloader),
+ scoped_ptr<Storage>(new FakeStorage));
+ const char kFallbackDataKey[] = "data/US";
+ bad_retriever.Retrieve(kFallbackDataKey, BuildCallback());
+
+ EXPECT_TRUE(success_);
+ EXPECT_EQ(kFallbackDataKey, key_);
+ EXPECT_FALSE(data_.empty());
please use gerrit instead 2014/01/16 00:50:15 Aslo this: EXPECT_NE(kEmptyData, data_); (kEmpty
Evan Stade 2014/01/16 01:09:10 Done.
+}
+
// The downloader that doesn't get back to you.
class HangingDownloader : public Downloader {
public:

Powered by Google App Engine
This is Rietveld 408576698