Chromium Code Reviews| Index: third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc |
| diff --git a/third_party/libaddressinput/chromium/cpp/test/fake_storage_test.cc b/third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc |
| similarity index 63% |
| copy from third_party/libaddressinput/chromium/cpp/test/fake_storage_test.cc |
| copy to third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc |
| index ee4137efe3de19adbbc7e14b9b40eb07838fac59..bed67da37f05d932dbc64a01166ba38c4792aa91 100644 |
| --- a/third_party/libaddressinput/chromium/cpp/test/fake_storage_test.cc |
| +++ b/third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc |
| @@ -1,4 +1,4 @@ |
| -// Copyright (C) 2013 Google Inc. |
| +// Copyright (C) 2014 Google Inc. |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| @@ -12,31 +12,26 @@ |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| -#include "fake_storage.h" |
| +#include "fallback_data_store.h" |
| #include <string> |
| #include <gtest/gtest.h> |
| -#include "storage_test_runner.h" |
| +#include "rule.h" |
| namespace i18n { |
| namespace addressinput { |
| namespace { |
| -// Tests for FakeStorage object. |
| -class FakeStorageTest : public testing::Test { |
| - protected: |
| - FakeStorageTest() : storage_(), runner_(&storage_) {} |
| - virtual ~FakeStorageTest() {} |
| +TEST(FallbackDataStore, Parsability) { |
| + std::string data; |
| + ASSERT_TRUE(FallbackDataStore::Get("data/US", &data)); |
| - FakeStorage storage_; |
| - StorageTestRunner runner_; |
| -}; |
| - |
| -TEST_F(FakeStorageTest, StandardStorageTests) { |
| - EXPECT_NO_FATAL_FAILURE(runner_.RunAllTests()); |
| + Rule rule; |
| + rule.CopyFrom(Rule::GetDefault()); |
| + EXPECT_TRUE(rule.ParseSerializedRule(data)); |
|
please use gerrit instead
2014/01/16 00:50:15
You should use Json::ParseObject() instead of Rule
Evan Stade
2014/01/16 01:09:10
Done.
|
| } |
| } // namespace |