Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: third_party/libaddressinput/chromium/cpp/src/retriever.h

Issue 137563004: libaddressinput: Add fallback data for US address validation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix fmt Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/src/retriever.h
diff --git a/third_party/libaddressinput/chromium/cpp/src/retriever.h b/third_party/libaddressinput/chromium/cpp/src/retriever.h
index 4749ee5146fad6c5bb805f9dfdeaa006451e26ae..a1371cf4fa4e618d910f86d4073073a237961d1f 100644
--- a/third_party/libaddressinput/chromium/cpp/src/retriever.h
+++ b/third_party/libaddressinput/chromium/cpp/src/retriever.h
@@ -32,7 +32,7 @@ namespace addressinput {
class Downloader;
class Storage;
-// Retrieves data. Sample usage:
+// Manages downloading data and caching it locally. Sample usage:
// Storage* storage = ...;
// Downloader* downloader = ...;
// Retriever retriever("https://i18napis.appspot.com/ssl-address/",
@@ -57,7 +57,7 @@ class Retriever {
// Callback for when a rule is retrieved from |storage_|.
void OnDataRetrievedFromStorage(bool success,
const std::string& key,
- const std::string& data);
+ const std::string& downloaded_data);
please use gerrit instead 2014/01/16 00:50:15 The .cc file renamed the variable for the OnDownlo
Evan Stade 2014/01/16 01:09:10 good catch, fixed.
// Callback for when a rule is retrieved by |downloader_|.
void OnDownloaded(bool success,

Powered by Google App Engine
This is Rietveld 408576698