Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java - Issue 137553005: DevTools: [JsDocValidator] Refactor JsDoc annotation checkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java

Issue 137553005: DevTools: [JsDocValidator] Refactor JsDoc annotation checkers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments from sergeyv Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java ('k') | Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java

diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java

index b7b71cb5e98069e8355b4385639c1ff8109a10d0..f29f301cd9300214212f55d2bb67364574ee0472 100644

--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java

+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java

@@ -32,6 +32,9 @@ public class ValidatorContext {

}

public String getNodeText(AstNode node) {

+ if (node == null) {

+ return null;

+ }

return scriptText.text.substring(

node.getAbsolutePosition(), node.getAbsolutePosition() + node.getLength());

}

@@ -66,7 +69,7 @@ public class ValidatorContext {

}

positionMarker.append('^');

int errorAbsolutePosition = node.getAbsolutePosition() + offsetInNodeText;

- String message = String.format("%s:%d: ERROR - %s\n%s\n%s\n",

+ String message = String.format("%s:%d: ERROR - %s%n%s%n%s%n",

scriptFileName,

position.line,

errorMessage,