Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2189)

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java

Issue 137553005: DevTools: [JsDocValidator] Refactor JsDoc annotation checkers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments from sergeyv Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java
diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ValidationCheck.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java
similarity index 51%
rename from Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ValidationCheck.java
rename to Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java
index 6398e32e132dce1b4509e76c8408652b87e5546b..2dfa1a9bc3cbb5b40e9e84f9c4640603f6ba1ce0 100644
--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ValidationCheck.java
+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java
@@ -1,7 +1,6 @@
-package org.chromium.devtools.jsdoc.checks;
+package org.chromium.devtools.jsdoc;
-import org.chromium.devtools.jsdoc.DoDidNodeVisitor;
-import org.chromium.devtools.jsdoc.ValidatorContext;
+import com.google.javascript.rhino.head.ast.AstNode;
/**
* A base class for all JSDoc validation checks.
@@ -10,13 +9,11 @@ public abstract class ValidationCheck implements DoDidNodeVisitor {
private ValidatorContext context;
- public void didTraverseTree() { }
-
- protected ValidatorContext getContext() {
- return context;
+ protected String getNodeText(AstNode node) {
+ return context.getNodeText(node);
}
- public void setContext(ValidatorContext context) {
+ protected void setContext(ValidatorContext context) {
if (this.context != null) {
throw new RuntimeException("ValidatorContext already set");
}

Powered by Google App Engine
This is Rietveld 408576698