Introduce a parameter to skip slow tests when running with a simulator.

Introduce a parameter to skip slow tests when running with a simulator.

The tests skipped have been tested and pass when given enough time.

R=rodolph.perfetta@arm.com, ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18899

[Alexandre Rames, 2014-01-28 11:18:24]

Hello,

This one touches some global files, so adding reviewers from Google.
This patch allows to filter tests according to if we are running on the
simulator.

Alexandre

[Rodolph Perfetta (ARM), 2014-01-28 11:44:34]

lgtm

[ulan, 2014-01-28 12:13:23]

lgtm

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
test/cctest/cctest.status:65: test-api/ExternalArrays: SKIP
Maybe 'PASS || TIMEOUT' instead of 'SKIP'? That could catch some crashes.

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
test/cctest/cctest.status:71: test-api/ExternalDoubleArray: SKIP
Did *Array tests finish on your machine?

https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status#...
test/mjsunit/mjsunit.status:133: array-sort: SKIP
Maybe 'PASS, (PASS || TIMEOUT) if $mode == debug' instead of 'SKIP'? That could
catch some crashes.

[ulan, 2014-01-28 12:25:37]

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
test/cctest/cctest.status:71: test-api/ExternalDoubleArray: SKIP
On 2014/01/28 12:13:23, ulan wrote:
> Did *Array tests finish on your machine?

I ran test-api/ExternalArrays and it finishes in ~20 minutes, so it should be OK
to skip these tests.

[Jakob Kummerow, 2014-01-28 12:28:45]

DBC.

I'm not super happy with changing behavior on simulator vs non-simulator runs,
but if you guys think this makes more sense than any alternative (always run,
always skip, always mark as timeout), then that's OK with me.

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
test/cctest/cctest.status:75: test-api/Fload32Array: SKIP
s/Fload/Float/ or this won't do what you want ;-)

[Rodolph Perfetta (ARM), 2014-01-28 13:30:49]

On 2014/01/28 12:28:45, Jakob wrote:
> DBC.
> 
> I'm not super happy with changing behavior on simulator vs non-simulator runs,
> but if you guys think this makes more sense than any alternative (always run,
> always skip, always mark as timeout), then that's OK with me.
> 
> https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
> File test/cctest/cctest.status (right):
> 
>
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
> test/cctest/cctest.status:75: test-api/Fload32Array: SKIP
> s/Fload/Float/ or this won't do what you want ;-)

I think we should review this flag once the a64 branch is merged to
bleeding_edge. Right now we are looking at a simple way to disable very slow
test for day testing and re-enable them overnight.

[Alexandre Rames, 2014-01-28 13:53:22]

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
test/cctest/cctest.status:65: test-api/ExternalArrays: SKIP
On 2014/01/28 12:13:23, ulan wrote:
> Maybe 'PASS || TIMEOUT' instead of 'SKIP'? That could catch some crashes.

Done.

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
test/cctest/cctest.status:71: test-api/ExternalDoubleArray: SKIP
On 2014/01/28 12:25:38, ulan wrote:
> On 2014/01/28 12:13:23, ulan wrote:
> > Did *Array tests finish on your machine?
> 
> I ran test-api/ExternalArrays and it finishes in ~20 minutes, so it should be
OK
> to skip these tests.

Yes I tested all of these, and they take ~17 minutes on my machine.

https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#ne...
test/cctest/cctest.status:75: test-api/Fload32Array: SKIP
On 2014/01/28 12:28:46, Jakob wrote:
> s/Fload/Float/ or this won't do what you want ;-)

Done.

https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/137543009/diff/1/test/mjsunit/mjsunit.status#...
test/mjsunit/mjsunit.status:133: array-sort: SKIP
On 2014/01/28 12:13:23, ulan wrote:
> Maybe 'PASS, (PASS || TIMEOUT) if $mode == debug' instead of 'SKIP'? That
could
> catch some crashes.

Done.

[Alexandre Rames, 2014-01-29 10:23:21]

Committed patchset #2 manually as r18899 (presubmit successful).