Issue 137543008: Calculate Underline thickness for Skia from Font metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137543008: Calculate Underline thickness for Skia from Font metrics (Closed)

Created:
6 years, 11 months ago by h.joshi

Modified:
6 years, 9 months ago

Reviewers:
Stephen Chennney, eae, abarth-chromium

Base URL:
https://chromium.googlesource.com/external/skia/include.git@master

Visibility:
Public.

More Reviews

Description

Calculate Underline thickness for Skia from Font metrics, same. Main Blink changes are done in patch https://codereview.chromium.org/147703002/ this also has update for Mac related to Underline thickness. BUG=338148

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	core/SkPaint.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

h.joshi

This patch is in continuation to base Blink patch https://codereview.chromium.org/147703002/. This adds underline thickness property ...

6 years, 10 months ago (2014-01-28 09:14:32 UTC) #1

h.joshi

Skia patch (https://codereview.chromium.org/152073003/) to Skia git repro is committed. On 2014/01/28 09:14:32, h.joshi wrote: > ...

6 years, 9 months ago (2014-03-03 14:35:26 UTC) #2

Stephen Chennney

not lgtm. I'm confused. This patch should be totally unnecessary. You already have modified Skia, ...

6 years, 9 months ago (2014-03-05 18:19:26 UTC) #3

h.joshi

6 years, 9 months ago (2014-03-06 04:19:07 UTC) #4

Yes this patch is not required. When I submitted this patch did not knew that
Skia patches needs to be submitted to Skia Git repo.

On 2014/03/05 18:19:26, Stephen Chenney wrote:
> not lgtm.
> 
> I'm confused. This patch should be totally unnecessary. You already have
> modified Skia, which is brought into the Chromium via a DEPS specification.
You
> should see your changes to the Skia repo reflected in the Chromium skia
> revision.

Expand Messages | Collapse Messages