core/SkPaint.h - Issue 137543008: Calculate Underline thickness for Skia from Font metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/SkPaint.h

Issue 137543008: Calculate Underline thickness for Skia from Font metrics (Closed) Base URL: https://chromium.googlesource.com/external/skia/include.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/SkPaint.h

diff --git a/core/SkPaint.h b/core/SkPaint.h

index 7dc3a4e03ccefb56e802b26fe4e38ee1d6a3a9e7..205a0b3009dbb6a1979b6df54751439f7e2bf0fb 100644

--- a/core/SkPaint.h

+++ b/core/SkPaint.h

@@ -742,6 +742,7 @@ public:

SkScalar fXMax; //!< The maximum bounding box x value for all glyphs

SkScalar fXHeight; //!< The height of an 'x' in px, or 0 if no 'x' in face

SkScalar fCapHeight; //!< The cap height (> 0), or 0 if cannot be determined.

+ SkScalar fUnderlineThickness; //!< underline thickness only for scalable fonts

};

/** Return the recommend spacing between lines (which will be

« no previous file with comments | « no previous file | no next file » | no next file with comments »