Output subsequence for children layers

Output subsequence for children layers

This is to ease paint property management. Subsequence now enclose
paintings of children layers, not including paintings of the layer
itself.

We need to distinguish subsequences for negative-z-order children
and normal-flow-and-positive-z-order children.

Committed: https://crrev.com/b99bf8b27b2a85a6bc9fe5204336cd8180b4073b
Cr-Commit-Position: refs/heads/master@{#351690}

[Xianzhu, 2015-09-30 22:30:56]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[pdr., 2015-09-30 23:11:56]

Sorry this turned out to be more involved than it seemed at first :/

Overall I like this approach.

https://chromiumcodereview.appspot.com/1375393002/diff/20001/third_party/WebK...
File third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp
(right):

https://chromiumcodereview.appspot.com/1375393002/diff/20001/third_party/WebK...
third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp:227:
paintingInfo.disableSubsequenceCache = true;
Does this need to be moved too?

https://chromiumcodereview.appspot.com/1375393002/diff/20001/third_party/WebK...
third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp:509: if
(!childPainter.shouldPaintLayerInSoftwareMode(paintingInfo.globalPaintFlags(),
paintFlags)) {
Nit: extra curly braces.

[Xianzhu, 2015-09-30 23:29:47]

https://chromiumcodereview.appspot.com/1375393002/diff/20001/third_party/WebK...
File third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp
(right):

https://chromiumcodereview.appspot.com/1375393002/diff/20001/third_party/WebK...
third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp:227:
paintingInfo.disableSubsequenceCache = true;
On 2015/09/30 23:11:56, pdr wrote:
> Does this need to be moved too?

Yes. This should control child subsequences. If not moved, it will also disable
caching of subsequences of this layer.

Done.

https://chromiumcodereview.appspot.com/1375393002/diff/20001/third_party/WebK...
third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp:509: if
(!childPainter.shouldPaintLayerInSoftwareMode(paintingInfo.globalPaintFlags(),
paintFlags)) {
On 2015/09/30 23:11:56, pdr wrote:
> Nit: extra curly braces.

Done.

[pdr., 2015-09-30 23:36:55]

LGTM

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
File third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp
(right):

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp:501: bool
disableChildSubsequenceCache = !RuntimeEnabledFeatures::slimmingPaintV2Enabled()
Nit: Should this be
!RuntimeEnabledFeatures::slimmingPaintSubsequenceCachingEnabled() ?

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
(right):

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp:42:
const DisplayItem::Type subsequenceType =
DisplayItem::SubsequenceNormalFlowAndPositiveZOrder;
Aren't these already defined in the header?

[Xianzhu, 2015-09-30 23:48:48]

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
File third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp
(right):

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp:501: bool
disableChildSubsequenceCache = !RuntimeEnabledFeatures::slimmingPaintV2Enabled()
On 2015/09/30 23:36:54, pdr wrote:
> Nit: Should this be
> !RuntimeEnabledFeatures::slimmingPaintSubsequenceCachingEnabled() ?

No. This is to workaround the effect of ancestor clip change on descendant for
spv1.

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
(right):

https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp:42:
const DisplayItem::Type subsequenceType =
DisplayItem::SubsequenceNormalFlowAndPositiveZOrder;
On 2015/09/30 23:36:54, pdr wrote:
> Aren't these already defined in the header?

These are defined in Source/core/paint/DisplayItemListPaintTest.h which is not
allowed to be included by this file.

[Xianzhu, 2015-09-30 23:48:53]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-09-30 23:50:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1375393002/10011
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1375393002/10011

[pdr., 2015-09-30 23:56:23]

On 2015/09/30 at 23:48:48, wangxianzhu wrote:
>
https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
> File third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp
(right):
> 
>
https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
> third_party/WebKit/Source/core/paint/DeprecatedPaintLayerPainter.cpp:501: bool
disableChildSubsequenceCache = !RuntimeEnabledFeatures::slimmingPaintV2Enabled()
> On 2015/09/30 23:36:54, pdr wrote:
> > Nit: Should this be
> > !RuntimeEnabledFeatures::slimmingPaintSubsequenceCachingEnabled() ?
> 
> No. This is to workaround the effect of ancestor clip change on descendant for
spv1.
> 
>
https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
> File third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
(right):
> 
>
https://chromiumcodereview.appspot.com/1375393002/diff/10011/third_party/WebK...
> third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp:42:
const DisplayItem::Type subsequenceType =
DisplayItem::SubsequenceNormalFlowAndPositiveZOrder;
> On 2015/09/30 23:36:54, pdr wrote:
> > Aren't these already defined in the header?
> 
> These are defined in Source/core/paint/DisplayItemListPaintTest.h which is not
allowed to be included by this file.

LGTM

[commit-bot: I haz the power, 2015-10-01 00:57:42]

Committed patchset #3 (id:10011)

[commit-bot: I haz the power, 2015-10-01 01:00:03]

Patchset 3 (id:??) landed as
https://crrev.com/b99bf8b27b2a85a6bc9fe5204336cd8180b4073b
Cr-Commit-Position: refs/heads/master@{#351690}