Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

Issue 1375393002: Output subsequence for children layers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix blink_platform_unittests and address pdr's comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
index 1615455d7c720edbcaf936084ce820cdfd9d9018..2ede61899aef3a5fa13f461e468f2e75515c96d2 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
@@ -165,9 +165,14 @@ public:
BeginFixedPositionContainer,
EndFixedPositionContainer,
- BeginSubsequence,
- EndSubsequence,
- CachedSubsequence,
+ SubsequenceFirst,
+ SubsequenceNegativeZOrder = SubsequenceFirst,
+ SubsequenceNormalFlowAndPositiveZOrder,
+ SubsequenceLast = SubsequenceNormalFlowAndPositiveZOrder,
+ EndSubsequenceFirst,
+ EndSubsequenceLast = EndSubsequenceFirst + SubsequenceLast - SubsequenceFirst,
+ CachedSubsequenceFirst,
+ CachedSubsequenceLast = CachedSubsequenceFirst + SubsequenceLast - SubsequenceFirst,
UninitializedType,
TypeLast = UninitializedType
@@ -228,8 +233,8 @@ public:
{
if (isCachedDrawingType(type))
return cachedDrawingTypeToDrawingType(type);
- if (type == CachedSubsequence)
- return BeginSubsequence;
+ if (isCachedSubsequenceType(type))
+ return cachedSubsequenceTypeToSubsequenceType(type);
return type;
}
@@ -307,11 +312,15 @@ public:
DEFINE_PAIRED_CATEGORY_METHODS(Scroll, scroll)
DEFINE_PAINT_PHASE_CONVERSION_METHOD(Scroll)
- DEFINE_PAIRED_CATEGORY_METHODS(Transform3D, transform3D);
+ DEFINE_PAIRED_CATEGORY_METHODS(Transform3D, transform3D)
- static bool isCachedType(Type type) { return isCachedDrawingType(type) || type == CachedSubsequence; }
+ DEFINE_PAIRED_CATEGORY_METHODS(Subsequence, subsequence)
+ DEFINE_CATEGORY_METHODS(CachedSubsequence)
+ DEFINE_CONVERSION_METHODS(Subsequence, subsequence, CachedSubsequence, cachedSubsequence)
+
+ static bool isCachedType(Type type) { return isCachedDrawingType(type) || isCachedSubsequenceType(type); }
bool isCached() const { return isCachedType(m_type); }
- static bool isCacheableType(Type type) { return isDrawingType(type) || type == BeginSubsequence; }
+ static bool isCacheableType(Type type) { return isDrawingType(type) || isSubsequenceType(type); }
bool isCacheable() const { return !skippedCache() && isCacheableType(m_type); }
virtual bool isBegin() const { return false; }

Powered by Google App Engine
This is Rietveld 408576698