Change bad input data to return a 403 instead of a 500.

Change bad input data to return a 403 instead of a 500.

BUG=537341
Committed: https://chromium.googlesource.com/infra/infra/+/5aeaecff9f8bea9e4016a3db553d9174d541e651

[estaab, 2015-09-30 18:25:04]

estaab@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2015-10-01 01:01:07]

Lgtm

On Wed, Sep 30, 2015, 11:25 AM  <estaab@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Change bad input data to return a 403 instead of a 500.
>
> BUG=537341
>
> Please review this at https://codereview.chromium.org/1375333003/
>
> Base URL: https://chromium.googlesource.com/infra/infra.git@master
>
> Affected files (+1, -1 lines):
>    M
> appengine/test_results/appengine_module/test_results/model/jsonresults.py
>
>
> Index:
> appengine/test_results/appengine_module/test_results/model/jsonresults.py
> diff --git
> a/appengine/test_results/appengine_module/test_results/model/jsonresults.py
> b/appengine/test_results/appengine_module/test_results/model/jsonresults.py
> index
>
>
783512f8240646f8423d8773adeb8146e9d7fbc9..3064a7d5a637e1510fc3f83d38074c3a8c00880d
> 100644
> ---
> a/appengine/test_results/appengine_module/test_results/model/jsonresults.py
> +++
> b/appengine/test_results/appengine_module/test_results/model/jsonresults.py
> @@ -617,7 +617,7 @@ class JsonResults(object):
>                    (JSON_RESULTS_FILE_SMALL, JSON_RESULTS_FILE))
>       if (is_full_results_format and
>           not cls.is_valid_full_results_json(results_json)):
> -      return ('Invalid full_results.json file.', 500)
> +      return ('Invalid full_results.json file.', 403)
>       small_file = cls._get_aggregate_file(
>           master, builder, test_type, JSON_RESULTS_FILE_SMALL,
> deprecated_master)
>       large_file = cls._get_aggregate_file(
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ojan, 2015-10-01 04:35:05]

The CQ bit was checked by ojan@chromium.org

[ojan, 2015-10-01 04:35:06]

lgtm

[commit-bot: I haz the power, 2015-10-01 04:35:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1375333003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1375333003/1

[commit-bot: I haz the power, 2015-10-01 04:38:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/5aeaecff9f8bea9e4016a3db553d9...