appengine/test_results/appengine_module/test_results/model/jsonresults.py - Issue 1375333003: Change bad input data to return a 403 instead of a 500.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/test_results/appengine_module/test_results/model/jsonresults.py

Issue 1375333003: Change bad input data to return a 403 instead of a 500. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/test_results/appengine_module/test_results/model/jsonresults.py

diff --git a/appengine/test_results/appengine_module/test_results/model/jsonresults.py b/appengine/test_results/appengine_module/test_results/model/jsonresults.py

index 783512f8240646f8423d8773adeb8146e9d7fbc9..3064a7d5a637e1510fc3f83d38074c3a8c00880d 100644

--- a/appengine/test_results/appengine_module/test_results/model/jsonresults.py

+++ b/appengine/test_results/appengine_module/test_results/model/jsonresults.py

@@ -617,7 +617,7 @@ class JsonResults(object):

(JSON_RESULTS_FILE_SMALL, JSON_RESULTS_FILE))

if (is_full_results_format and

not cls.is_valid_full_results_json(results_json)):

- return ('Invalid full_results.json file.', 500)

+ return ('Invalid full_results.json file.', 403)

small_file = cls._get_aggregate_file(

master, builder, test_type, JSON_RESULTS_FILE_SMALL, deprecated_master)

large_file = cls._get_aggregate_file(

« no previous file with comments | « no previous file | no next file » | no next file with comments »