mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc - Issue 1375313006: For c++, Generate enum classes instead of enum from mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

Issue 1375313006: For c++, Generate enum classes instead of enum from mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/mojom_cpp_generator.py ('K') | « mojo/services/view_manager/public/cpp/lib/view.cc ('k') | mojo/services/view_manager/public/cpp/tests/view_unittest.cc » ('j') | services/view_manager/scheduled_animation_group.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

diff --git a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

index 52d1b48c5d6581af47a8e65118045592fac5bb09..b8262d1a95a8c5277fea0ceb001ec3b233662369 100644

--- a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

+++ b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

@@ -242,7 +242,7 @@ Id ViewManagerClientImpl::CreateViewOnServer() {

DCHECK(service_);

const Id view_id = MakeTransportId(connection_id_, ++next_id_);

service_->CreateView(view_id, [this](ErrorCode code) {

- OnActionCompleted(code == ERROR_CODE_NONE);

+ OnActionCompleted(code == ErrorCode::NONE);

});

return view_id;

}