For c++, Generate enum classes instead of enum from mojom.

services/view_manager/scheduled_animation_group.cc

Index: services/view_manager/scheduled_animation_group.cc
diff --git a/services/view_manager/scheduled_animation_group.cc b/services/view_manager/scheduled_animation_group.cc
index b32111b82ee8d7e22652403be0dc652fdf1ddf80..70c62a669033170d1bd51cf9a2d10c0fee494375 100644
--- a/services/view_manager/scheduled_animation_group.cc
+++ b/services/view_manager/scheduled_animation_group.cc
@@ -9,9 +9,9 @@
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "services/view_manager/server_view.h"
 
-using mojo::ANIMATION_PROPERTY_NONE;
-using mojo::ANIMATION_PROPERTY_OPACITY;
-using mojo::ANIMATION_PROPERTY_TRANSFORM;
+using mojo::AnimationProperty::NONE;

[viettrungluu, 2015/10/01 17:49:55]

These ones are now redundant; the single |using mojo::AnimationProperty;| is now
sufficient.

[johngro, 2015/10/02 00:49:04]

Done.

FWIW - this was done by my script, I do not think that I ever layed eyes on this
file.  There may be other instances of this sort of stuff.  Whether or not you
want to track them all down is up to you.

+using mojo::AnimationProperty::OPACITY;
+using mojo::AnimationProperty::TRANSFORM;
 using mojo::AnimationProperty;
 
 namespace view_manager {
@@ -24,13 +24,13 @@ void GetValueFromView(const ServerView* view,
                       AnimationProperty property,
                       ScheduledAnimationValue* value) {
   switch (property) {
-    case ANIMATION_PROPERTY_NONE:
+    case AnimationProperty::NONE:
       NOTREACHED();
       break;
-    case ANIMATION_PROPERTY_OPACITY:
+    case AnimationProperty::OPACITY:
       value->float_value = view->opacity();
       break;
-    case ANIMATION_PROPERTY_TRANSFORM:
+    case AnimationProperty::TRANSFORM:
       value->transform = view->transform();
       break;
   }
@@ -41,12 +41,12 @@ void SetViewPropertyFromValue(ServerView* view,
                               AnimationProperty property,
                               const ScheduledAnimationValue& value) {
   switch (property) {
-    case ANIMATION_PROPERTY_NONE:
+    case AnimationProperty::NONE:
       break;
-    case ANIMATION_PROPERTY_OPACITY:
+    case AnimationProperty::OPACITY:
       view->SetOpacity(value.float_value);
       break;
-    case ANIMATION_PROPERTY_TRANSFORM:
+    case AnimationProperty::TRANSFORM:
       view->SetTransform(value.transform);
       break;
   }
@@ -61,13 +61,13 @@ void SetViewPropertyFromValueBetween(ServerView* view,
                                      const ScheduledAnimationValue& target) {
   const double tween_value = gfx::Tween::CalculateValue(tween_type, value);
   switch (property) {
-    case ANIMATION_PROPERTY_NONE:
+    case AnimationProperty::NONE:
       break;
-    case ANIMATION_PROPERTY_OPACITY:
+    case AnimationProperty::OPACITY:
       view->SetOpacity(gfx::Tween::FloatValueBetween(
           tween_value, start.float_value, target.float_value));
       break;
-    case ANIMATION_PROPERTY_TRANSFORM:
+    case AnimationProperty::TRANSFORM:
       view->SetTransform(gfx::Tween::TransformValueBetween(
           tween_value, start.transform, target.transform));
       break;
@@ -76,13 +76,13 @@ void SetViewPropertyFromValueBetween(ServerView* view,
 
 gfx::Tween::Type AnimationTypeToTweenType(mojo::AnimationTweenType type) {
   switch (type) {
-    case mojo::ANIMATION_TWEEN_TYPE_LINEAR:
+    case mojo::AnimationTweenType::LINEAR:
       return gfx::Tween::LINEAR;
-    case mojo::ANIMATION_TWEEN_TYPE_EASE_IN:
+    case mojo::AnimationTweenType::EASE_IN:
       return gfx::Tween::EASE_IN;
-    case mojo::ANIMATION_TWEEN_TYPE_EASE_OUT:
+    case mojo::AnimationTweenType::EASE_OUT:
       return gfx::Tween::EASE_OUT;
-    case mojo::ANIMATION_TWEEN_TYPE_EASE_IN_OUT:
+    case mojo::AnimationTweenType::EASE_IN_OUT:
       return gfx::Tween::EASE_IN_OUT;
   }
   return gfx::Tween::LINEAR;
@@ -100,7 +100,7 @@ void ConvertToScheduledElement(const mojo::AnimationElement& transport_element,
   element->duration =
       base::TimeDelta::FromMicroseconds(transport_element.duration);
   element->tween_type = AnimationTypeToTweenType(transport_element.tween_type);
-  if (transport_element.property != ANIMATION_PROPERTY_NONE) {
+  if (transport_element.property != AnimationProperty::NONE) {
     if (transport_element.start_value.get()) {
       element->is_start_valid = true;
       ConvertToScheduledValue(*transport_element.start_value,
@@ -116,19 +116,19 @@ void ConvertToScheduledElement(const mojo::AnimationElement& transport_element,
 bool IsAnimationValueValid(AnimationProperty property,
                            const mojo::AnimationValue& value) {
   switch (property) {
-    case ANIMATION_PROPERTY_NONE:
+    case AnimationProperty::NONE:
       NOTREACHED();
       return false;
-    case ANIMATION_PROPERTY_OPACITY:
+    case AnimationProperty::OPACITY:
       return value.float_value >= 0.f && value.float_value <= 1.f;
-    case ANIMATION_PROPERTY_TRANSFORM:
+    case AnimationProperty::TRANSFORM:
       return value.transform.get() && value.transform->matrix.size() == 16u;
   }
   return false;
 }
 
 bool IsAnimationElementValid(const mojo::AnimationElement& element) {
-  if (element.property == ANIMATION_PROPERTY_NONE)
+  if (element.property == AnimationProperty::NONE)
     return true;  // None is a pause and doesn't need any values.
   if (element.start_value.get() &&
       !IsAnimationValueValid(element.property, *element.start_value))
@@ -163,7 +163,7 @@ bool IsAnimationGroupValid(const mojo::AnimationGroup& transport_group) {
 // is obtained from |view| and placed into |element|.
 void GetStartValueFromViewIfNecessary(const ServerView* view,
                                       ScheduledAnimationElement* element) {
-  if (element->property != ANIMATION_PROPERTY_NONE &&
+  if (element->property != AnimationProperty::NONE &&
       !element->is_start_valid) {
     GetValueFromView(view, element->property, &(element->start_value));
   }
@@ -265,7 +265,7 @@ ScheduledAnimationValue::~ScheduledAnimationValue() {
 }
 
 ScheduledAnimationElement::ScheduledAnimationElement()
-    : property(ANIMATION_PROPERTY_OPACITY),
+    : property(AnimationProperty::OPACITY),
       tween_type(gfx::Tween::EASE_IN),
       is_start_valid(false) {
 }
@@ -317,7 +317,7 @@ void ScheduledAnimationGroup::SetValuesToTargetValuesForPropertiesNotIn(
 
   for (AnimationProperty property : our_properties) {
     if (other_properties.count(property) == 0 &&
-        property != ANIMATION_PROPERTY_NONE) {
+        property != AnimationProperty::NONE) {
       SetPropertyToTargetProperty(view_, property, sequences_);
     }
   }