isolate: add run_isolated, deprecate runtest

scripts/slave/recipe_modules/isolate/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine import recipe_api
 
 
 class IsolateApi(recipe_api.RecipeApi):
   """APIs for interacting with isolates."""
 
@@ skipping 195 matching lines @@
       # Always append '--' to the argument list. api.chromium.runtest
       # will add any flags like --gtest_output to the end of the command
       # line. run_isolated.py must treat these as extra arguments to the
       # isolate.
       '--'
     ]
     if args:
       full_args.extend(args)
     return full_args
 
+  def run_isolated(self, name, isolate_hash, args=None):
+    """Runs an isolated test."""
+    self.m.python(
+        name,
+        self._run_isolated_path,
+        [
+            '--isolated', isolate_hash,
+            '-I', self.isolate_server,
+            '--verbose',

[M-A Ruel, 2015/09/29 12:21:39]

Remove, unless it's to test out then remove later.

[Paweł Hajdan Jr., 2015/09/29 12:25:40]

It's intentional - and as discussed offline, my understanding is that's okay for
you.

+            '--',

[M-A Ruel, 2015/09/29 12:21:39]

Personally, I'd prefer '--' to not be added when args is empty;

cmd = [
...
]
if args:
  cmd.append('--')
  cmd.extend(args)

It'd be nicer IMHO but not a big deal.

[Paweł Hajdan Jr., 2015/09/29 12:25:40]

Done.

+        ] + (args or []))
+
   def runtest(self, test, revision, webkit_revision, args=None, name=None,
               **runtest_kwargs):
     """Runs a test which has previously been isolated to the server.
 
     Uses runtest_args_list, above, and delegates to api.chromium.runtest.
+
+    DEPRECATED - run_isolated above is strongly recommended for all new callers.
     """
     self.m.chromium.runtest(
         self._run_isolated_path,
         args=self.runtest_args_list(test, args),
         # We must use the name of the test as the name in order to avoid
         # duplicate steps called "run_isolated".
         name=name or test,
         revision=revision,
         webkit_revision=webkit_revision,
         **runtest_kwargs)
@@ skipping 37 matching lines @@
     """Compare the artifacts from 2 builds."""
     args = [
         '--first-build-dir', first_dir,
         '--second-build-dir', second_dir,
         '--target-platform', self.m.chromium.c.TARGET_PLATFORM
     ]
     self.m.python('compare_build_artifacts',
                   self.resource('compare_build_artifacts.py'),
                   args=args,
                   cwd=self.m.path['slave_build'])