Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1374933002: Fix false negatives in system key events recognition (Closed)

Created:
5 years, 2 months ago by joleksy
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix false negatives in system key events recognition Cmd + <some other modifier> + (b|i) should be treated as a system key event. This was already reviewed in https://codereview.chromium.org/1215633003/ now rebased to new project structure. Committed: https://crrev.com/914cedebca040969b4df294e6731b2db7f967a37 Cr-Commit-Position: refs/heads/master@{#351374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 1 chunk +10 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm View 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
joleksy
@reviewer: does it look (still) ok to you?
5 years, 2 months ago (2015-09-29 12:13:22 UTC) #2
Mike West
(still) LGTM.
5 years, 2 months ago (2015-09-29 12:41:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374933002/1
5 years, 2 months ago (2015-09-29 12:46:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104684)
5 years, 2 months ago (2015-09-29 12:56:01 UTC) #7
joleksy
On 2015/09/29 12:56:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-09-29 13:11:31 UTC) #9
aelias_OOO_until_Jul13
rubberstamp lgtm
5 years, 2 months ago (2015-09-29 18:49:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374933002/1
5 years, 2 months ago (2015-09-29 19:33:12 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 19:40:10 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 19:40:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/914cedebca040969b4df294e6731b2db7f967a37
Cr-Commit-Position: refs/heads/master@{#351374}

Powered by Google App Engine
This is Rietveld 408576698