Fix false negatives in system key events recognition

content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/web_input_event_builders_mac.h"
 
 #import <Cocoa/Cocoa.h>
+#include <Carbon/Carbon.h>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/events/keycodes/dom/dom_code.h"
 #include "ui/events/keycodes/dom/dom_key.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 using blink::WebKeyboardEvent;
 using blink::WebInputEvent;
 using content::WebKeyboardEventBuilder;
 
@@ skipping 182 matching lines @@
     const ModifierKey& key = kModifierKeys[i];
     NSEvent* mac_event = BuildFakeKeyEvent(
         key.mac_key_code, 0, key.non_specific_mask, NSFlagsChanged);
     WebKeyboardEvent web_event = WebKeyboardEventBuilder::Build(mac_event);
     EXPECT_EQ(WebInputEvent::RawKeyDown, web_event.type);
     mac_event = BuildFakeKeyEvent(key.mac_key_code, 0, 0, NSFlagsChanged);
     web_event = WebKeyboardEventBuilder::Build(mac_event);
     EXPECT_EQ(WebInputEvent::KeyUp, web_event.type);
   }
 }
+
+// Test system key events recognition.
+TEST(WebInputEventBuilderMacTest, SystemKeyEvents) {
+  // Cmd + B should not be treated as system event.
+  NSEvent* macEvent =
+      BuildFakeKeyEvent(kVK_ANSI_B, 'B', NSCommandKeyMask, NSKeyDown);
+  WebKeyboardEvent webEvent = WebKeyboardEventBuilder::Build(macEvent);
+  EXPECT_FALSE(webEvent.isSystemKey);
+
+  // Cmd + I should not be treated as system event.
+  macEvent = BuildFakeKeyEvent(kVK_ANSI_I, 'I', NSCommandKeyMask, NSKeyDown);
+  webEvent = WebKeyboardEventBuilder::Build(macEvent);
+  EXPECT_FALSE(webEvent.isSystemKey);
+
+  // Cmd + <some other modifier> + <B|I> should be treated as system event.
+  macEvent = BuildFakeKeyEvent(kVK_ANSI_B, 'B',
+                               NSCommandKeyMask | NSShiftKeyMask, NSKeyDown);
+  webEvent = WebKeyboardEventBuilder::Build(macEvent);
+  EXPECT_TRUE(webEvent.isSystemKey);
+  macEvent = BuildFakeKeyEvent(kVK_ANSI_I, 'I',
+                               NSCommandKeyMask | NSControlKeyMask, NSKeyDown);
+  webEvent = WebKeyboardEventBuilder::Build(macEvent);
+  EXPECT_TRUE(webEvent.isSystemKey);
+
+  // Cmd + <any letter other then B and I> should be treated as system event.
+  macEvent = BuildFakeKeyEvent(kVK_ANSI_S, 'S', NSCommandKeyMask, NSKeyDown);
+  webEvent = WebKeyboardEventBuilder::Build(macEvent);
+  EXPECT_TRUE(webEvent.isSystemKey);
+
+  // Cmd + <some other modifier> + <any letter other then B and I> should be
+  // treated as system event.
+  macEvent = BuildFakeKeyEvent(kVK_ANSI_S, 'S',
+                               NSCommandKeyMask | NSShiftKeyMask, NSKeyDown);
+  webEvent = WebKeyboardEventBuilder::Build(macEvent);
+  EXPECT_TRUE(webEvent.isSystemKey);
+}