Retry HttpNetworkTransactions upon receipt of ERR_NETWORK_CHANGED during host resolution and …

net/url_request/url_request.cc

Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 46f3a18c219cb7e594f9eeb7a228694dc87f1a54..1e96d00686047926641c31fb2ae45690b5980a63 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -46,6 +46,9 @@ namespace {
 
 // Max number of http redirects to follow.  Same number as gecko.
 const int kMaxRedirects = 20;
+// Default maximum number of times to retry a request after receiving
+// ERR_NETWORK_CHANGED.
+const int kDefaultMaxAutomaticRetriesOnNetworkChanges = 3;

[mmenke, 2014/02/13 20:20:17]

Think it's a bit confusing to have max retries, instead of max tries.  I think
it's ambiguous if the first try a "retry" or not?  Your comment here makes it
clear, but best not to have to duplicate it everywhere.

 
 // Discard headers which have meaning in POST (Content-Length, Content-Type,
 // Origin).
@@ -227,6 +230,8 @@ URLRequest::URLRequest(const GURL& url,
       before_request_callback_(base::Bind(&URLRequest::BeforeRequestComplete,
                                           base::Unretained(this))),
       has_notified_completion_(false),
+      max_automatic_retries_on_network_changes_(
+          kDefaultMaxAutomaticRetriesOnNetworkChanges),
       received_response_content_length_(0),
       creation_time_(base::TimeTicks::Now()),
       notified_before_network_start_(false) {