Retry HttpNetworkTransactions upon receipt of ERR_NETWORK_CHANGED during host resolution and …

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 28 matching lines @@
 
 using base::Time;
 using std::string;
 
 namespace net {
 
 namespace {
 
 // Max number of http redirects to follow.  Same number as gecko.
 const int kMaxRedirects = 20;
+// Default maximum number of times to retry a request after receiving
+// ERR_NETWORK_CHANGED.
+const int kDefaultMaxAutomaticRetriesOnNetworkChanges = 3;

[mmenke, 2014/02/13 20:20:17]

Think it's a bit confusing to have max retries, instead of max tries.  I think
it's ambiguous if the first try a "retry" or not?  Your comment here makes it
clear, but best not to have to duplicate it everywhere.

 
 // Discard headers which have meaning in POST (Content-Length, Content-Type,
 // Origin).
 void StripPostSpecificHeaders(HttpRequestHeaders* headers) {
   // These are headers that may be attached to a POST.
   headers->RemoveHeader(HttpRequestHeaders::kContentLength);
   headers->RemoveHeader(HttpRequestHeaders::kContentType);
   headers->RemoveHeader(HttpRequestHeaders::kOrigin);
 }
 
@@ skipping 161 matching lines @@
       is_pending_(false),
       is_redirecting_(false),
       redirect_limit_(kMaxRedirects),
       priority_(priority),
       identifier_(GenerateURLRequestIdentifier()),
       calling_delegate_(false),
       use_blocked_by_as_load_param_(false),
       before_request_callback_(base::Bind(&URLRequest::BeforeRequestComplete,
                                           base::Unretained(this))),
       has_notified_completion_(false),
+      max_automatic_retries_on_network_changes_(
+          kDefaultMaxAutomaticRetriesOnNetworkChanges),
       received_response_content_length_(0),
       creation_time_(base::TimeTicks::Now()),
       notified_before_network_start_(false) {
   SIMPLE_STATS_COUNTER("URLRequestCount");
 
   // Sanity check out environment.
   DCHECK(base::MessageLoop::current())
       << "The current base::MessageLoop must exist";
 
   CHECK(context);
@@ skipping 993 matching lines @@
       new base::debug::StackTrace(NULL, 0);
   *stack_trace_copy = stack_trace;
   stack_trace_.reset(stack_trace_copy);
 }
 
 const base::debug::StackTrace* URLRequest::stack_trace() const {
   return stack_trace_.get();
 }
 
 }  // namespace net