Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: net/url_request/url_fetcher_core.cc

Issue 137493008: Retry HttpNetworkTransactions upon receipt of ERR_NETWORK_CHANGED during host resolution and … Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Flush task queue before restart Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_fetcher_core.cc
diff --git a/net/url_request/url_fetcher_core.cc b/net/url_request/url_fetcher_core.cc
index e2fcc450219e50585bb9a57e932f116d700c6dc8..18cc87f31d5850bd6866c096b60ab3f282b9ad38 100644
--- a/net/url_request/url_fetcher_core.cc
+++ b/net/url_request/url_fetcher_core.cc
@@ -521,6 +521,10 @@ void URLFetcherCore::StartURLRequest() {
request_->SetUserData(url_request_data_key_,
url_request_create_data_callback_.Run());
}
+ // Don't duplicate retrying in both URLFetcher and URLRequest as this can have
+ // a multiplicative effect.
+ if (max_retries_on_network_changes_)
mmenke 2014/02/13 20:20:17 I think it's weird to have two ways to do this. A
+ request_->set_max_automatic_retries_on_network_changes(0);
switch (request_type_) {
case URLFetcher::GET:

Powered by Google App Engine
This is Rietveld 408576698