Retry HttpNetworkTransactions upon receipt of ERR_NETWORK_CHANGED during host resolution and …

net/url_request/url_fetcher_core.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_fetcher_core.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/sequenced_task_runner.h"
@@ skipping 503 matching lines @@
   if (is_chunked_upload_)
     request_->EnableChunkedUpload();
   request_->SetLoadFlags(flags);
   request_->SetReferrer(referrer_);
   request_->set_first_party_for_cookies(first_party_for_cookies_.is_empty() ?
       original_url_ : first_party_for_cookies_);
   if (url_request_data_key_ && !url_request_create_data_callback_.is_null()) {
     request_->SetUserData(url_request_data_key_,
                           url_request_create_data_callback_.Run());
   }
+  // Don't duplicate retrying in both URLFetcher and URLRequest as this can have
+  // a multiplicative effect.
+  if (max_retries_on_network_changes_)

[mmenke, 2014/02/13 20:20:17]

I think it's weird to have two ways to do this.  Admittedly, this implementation
will re-send requests, even rePOSTing if needed, but I'm not a huge fan of
having two mechanisms to do this.  May not have a choice, though.  Should look
at callsites, I think.

+    request_->set_max_automatic_retries_on_network_changes(0);
 
   switch (request_type_) {
     case URLFetcher::GET:
       break;
 
     case URLFetcher::POST:
     case URLFetcher::PUT:
     case URLFetcher::PATCH:
       // Upload content must be set.
       DCHECK(is_chunked_upload_ || upload_content_set_);
@@ skipping 353 matching lines @@
 }
 
 void URLFetcherCore::InformDelegateDownloadProgressInDelegateThread(
     int64 current, int64 total) {
   DCHECK(delegate_task_runner_->BelongsToCurrentThread());
   if (delegate_)
     delegate_->OnURLFetchDownloadProgress(fetcher_, current, total);
 }
 
 }  // namespace net