Chromium Code Reviews Chromium Code Reviews
Issue
137493003:
Appcache::OnCorruptionDetected handling (Closed)
DescriptionAppcache::OnCorruptionDetected handling. The general idea is to delete everything and start over (reinitialize) if we notice corruption on disk. The is some pre-existing code to perform the reinitialization function, but that was only used in a more narrow case where the disk cache could not have been open. With the changes in this CL, reinitialization can be triggered pretty much at any time.
* The AppCacheDatabase classes uses an SQLConnecton ErrorHandler to detect catastrophic errors (corruption).
* The AppCacheStorageImpl's DatabaseTask class checks for having seen corruption during a task and initiates a heavy handed operation to delete everything and start over.
* The AppCacheStorageImpl::InitTask also checks for the presence of a stale/undeletable DiskCache when there is no SQL database. If found, that also triggers reinitialization.
* The AppCacheService class does exponential backoff to avoid thrashing the disk on repeated reinit attempts.
* The AppCacheDiskCache class's Disable() method has been modified such that all file handles get released.
TBR=jam
BUG=318544
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247967
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248642
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #Patch Set 6 : #
Total comments: 1
Patch Set 7 : #Patch Set 8 : #Patch Set 9 : #Patch Set 10 : #
Total comments: 18
Patch Set 11 : #
Total comments: 11
Patch Set 12 : #Patch Set 13 : #
Total comments: 1
Patch Set 14 : #
Total comments: 3
Patch Set 15 : #Messages
Total messages: 39 (0 generated)
|
