Appcache::OnCorruptionDetected handling

webkit/browser/appcache/appcache_storage_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_BROWSER_APPCACHE_APPCACHE_STORAGE_IMPL_H_
 #define WEBKIT_BROWSER_APPCACHE_APPCACHE_STORAGE_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 49 matching lines @@
       const GURL& manifest_url, int64 group_id, int64 response_id) OVERRIDE;
   virtual AppCacheResponseWriter* CreateResponseWriter(
       const GURL& manifest_url, int64 group_id) OVERRIDE;
   virtual void DoomResponses(const GURL& manifest_url,
                              const std::vector<int64>& response_ids) OVERRIDE;
   virtual void DeleteResponses(const GURL& manifest_url,
                                const std::vector<int64>& response_ids) OVERRIDE;
   virtual void PurgeMemory() OVERRIDE;
 
  private:
-  friend class AppCacheStorageImplTest;
-
   // The AppCacheStorageImpl class methods and datamembers may only be
   // accessed on the IO thread. This class manufactures seperate DatabaseTasks
   // which access the DB on a seperate background thread.
   class DatabaseTask;
   class InitTask;
   class CloseConnectionTask;
   class DisableDatabaseTask;
   class GetAllInfoTask;
   class StoreOrLoadTask;
   class CacheLoadTask;
@@ skipping 25 matching lines @@
   void ScheduleSimpleTask(const base::Closure& task);
   void RunOnePendingSimpleTask();
 
   void DelayedStartDeletingUnusedResponses();
   void StartDeletingResponses(const std::vector<int64>& response_ids);
   void ScheduleDeleteOneResponse();
   void DeleteOneResponse();
 
   void OnDeletedOneResponse(int rv);
   void OnDiskCacheInitialized(int rv);
-  void CallReinitialize();
+  void DeleteAndStartOver();
+  void DeleteAndStartOverPart2();

[kinuko, 2014/01/29 07:40:30]

(totally optional) Part2 sounds nice, but it might be slightly clearer to say
what each does like...

PostDeleteAndStartOver()
DeleteAndStartOver()

+  void CallScheduleReinitialize();
 
   // Sometimes we can respond without having to query the database.
   bool FindResponseForMainRequestInGroup(
       AppCacheGroup* group,  const GURL& url, Delegate* delegate);
   void DeliverShortCircuitedFindMainResponse(
       const GURL& url,
       const AppCacheEntry& found_entry,
       scoped_refptr<AppCacheGroup> group,
       scoped_refptr<AppCache> newest_cache,
       scoped_refptr<DelegateReference> delegate_ref);
@@ skipping 37 matching lines @@
   // disk cache and cannot continue.
   bool is_disabled_;
 
   scoped_ptr<AppCacheDiskCache> disk_cache_;
 
   // Used to short-circuit certain operations without having to schedule
   // any tasks on the background database thread.
   std::deque<base::Closure> pending_simple_tasks_;
   base::WeakPtrFactory<AppCacheStorageImpl> weak_factory_;
 
+  friend class AppCacheStorageImplTest;
   friend class content::ChromeAppCacheServiceTest;
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_BROWSER_APPCACHE_APPCACHE_STORAGE_IMPL_H_