runtime/vm/native_entry.h - Issue 137483010: Add more timing information in the VM to track time spent is dart code Vs native code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.h

Issue 137483010: Add more timing information in the VM to track time spent is dart code Vs native code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/native_entry.h

===================================================================

--- runtime/vm/native_entry.h (revision 32801)

+++ runtime/vm/native_entry.h (working copy)

@@ -10,6 +10,7 @@

#include "vm/code_generator.h"

#include "vm/exceptions.h"

#include "vm/native_arguments.h"

+#include "vm/timer_scope.h"

#include "vm/verifier.h"

#include "include/dart_api.h"

@@ -40,8 +41,9 @@

NativeArguments* arguments); \

void NATIVE_ENTRY_FUNCTION(name)(Dart_NativeArguments args) { \

CHECK_STACK_ALIGNMENT; \

+ NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args); \

+ DartToVmTimerScope timer(arguments->isolate()); \

VERIFY_ON_TRANSITION; \

- NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args); \

ASSERT(arguments->NativeArgCount() == argument_count); \

TRACE_NATIVE_CALL("%s", ""#name); \

{ \

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »