Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: runtime/vm/isolate.cc

Issue 137483010: Add more timing information in the VM to track time spent is dart code Vs native code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/native_entry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
===================================================================
--- runtime/vm/isolate.cc (revision 32801)
+++ runtime/vm/isolate.cc (working copy)
@@ -104,9 +104,6 @@
StartIsolateScope start_scope(isolate_);
StackZone zone(isolate_);
HandleScope handle_scope(isolate_);
- // TODO(turnidge): Rework collection total dart execution. This can
- // overcount when other things (gc, compilation) are active.
- TIMERSCOPE(time_dart_execution);
// If the message is in band we lookup the receive port to dispatch to. If
// the receive port is closed, we drop the message without deserializing it.
@@ -255,6 +252,7 @@
// Invoke the isolate's unhandled exception callback if there is one.
if (Isolate::UnhandledExceptionCallback() != NULL) {
+ VmToNativeTimerScope timer(Isolate::Current());
Dart_EnterScope();
Dart_Handle error = Api::NewHandle(isolate_, result.raw());
(Isolate::UnhandledExceptionCallback())(error);
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/native_entry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698