Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1374783005: TextAutosizer should handle frames without a FrameView. (Closed)

Created:
5 years, 2 months ago by nasko
Modified:
5 years, 2 months ago
Reviewers:
skobes
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TextAutosizer should handle frames without a FrameView. During cross-process navigation, it is possible to create a LocalFrame that doesn't have a FrameView, since the latter gets created at the time a document commits. Since the commit in this case happens later in time, the current code crashes as it expects the view to be there. BUG=357747 Committed: https://crrev.com/6bdf645df32dbfa0ff4ae4925468519800f74827 Cr-Commit-Position: refs/heads/master@{#351204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nasko
Hello skobes@, Can you please review this CL for me? Thanks in advance! Nasko
5 years, 2 months ago (2015-09-28 22:14:20 UTC) #2
skobes
lgtm
5 years, 2 months ago (2015-09-28 22:23:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374783005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374783005/1
5 years, 2 months ago (2015-09-28 22:30:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 23:45:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 23:46:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bdf645df32dbfa0ff4ae4925468519800f74827
Cr-Commit-Position: refs/heads/master@{#351204}

Powered by Google App Engine
This is Rietveld 408576698