chrome/browser/BUILD.gn - Issue 1374773002: Componentize script to generate UI string overrides mapping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index

Patch Set: Rebase and fix //components/variations:unit_tests build with gn Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 7cf2714d1e4967ebcc6dbd21130cc5d08adc5d81..7cf8f2233f3e879823b63a766ece38524292b88f 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -94,9 +94,9 @@ source_set("browser") {

"//chrome:extra_resources",

"//chrome:resources",

"//chrome:strings",

- "//chrome/app:generated_resources_map",

"//chrome/app/resources:platform_locale_settings",

"//chrome/app/theme:theme_resources",

+ "//chrome/browser/metrics/variations:chrome_ui_string_overrider_factory",

"//chrome/browser/net:probe_message_proto",

"//chrome/browser/ui",

"//chrome/common",

@@ -264,9 +264,9 @@ source_set("browser") {

deps += [

"//apps",

"//cc",

- "//chrome/app:generated_resources_map",

"//chrome/app/theme:theme_resources",

"//chrome/browser/devtools",

+ "//chrome/browser/metrics/variations:chrome_ui_string_overrider_factory",

"//chrome/browser/resources:component_extension_resources",

"//chrome/common/net",

"//chrome/installer/util",

« no previous file with comments | « chrome/app/BUILD.gn ('k') | chrome/browser/metrics/metrics_services_manager.cc » ('j') | no next file with comments »