Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Unified Diff: chrome/app/BUILD.gn

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index
Patch Set: Rebase and fix //components/variations:unit_tests build with gn Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/BUILD.gn
diff --git a/chrome/app/BUILD.gn b/chrome/app/BUILD.gn
index c4525c95bcd6a65cf2714671deaae3fc0158cf3d..16673277c20ef63b612b2eba26709c787819b958 100644
--- a/chrome/app/BUILD.gn
+++ b/chrome/app/BUILD.gn
@@ -134,38 +134,6 @@ if (is_android) {
}
}
-# GYP version: chrome/chrome_resources.gyp:chrome_strings_map
-action("make_generated_resources_map") {
- # Targets should depend on generated_resources_map instead.
- visibility = [ ":generated_resources_map" ]
-
- script = "//chrome/browser/metrics/variations/generate_resources_map.py"
-
- inputs = [
- "$root_gen_dir/chrome/grit/generated_resources.h",
- ]
- outputs = [
- "$root_gen_dir/chrome/generated_resources_map.cc",
- ]
-
- args =
- rebase_path(inputs, root_build_dir) + rebase_path(outputs, root_build_dir)
-
- deps = [
- ":generated_resources",
- ]
-}
-
-# Collect the generated .cc file from make_generated_resources_map and put it
-# in a source set so targets that depend on it will link the source rather than
-# specifying it manually. This doesn't happen in the GYP build.
-source_set("generated_resources_map") {
- sources = get_target_outputs(":make_generated_resources_map")
- deps = [
- ":make_generated_resources_map",
- ]
-}
-
# GYP version: chrome/chrome_resources.gyp:chrome_strings
# (generate_google_chrome_strings action)
grit("google_chrome_strings") {
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698