Issue 1374763003: Revert of SkImage-backed SkPictureShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374763003: Revert of SkImage-backed SkPictureShader (Closed)

Created:
5 years, 2 months ago by robertphillips

Modified:
5 years, 2 months ago

Reviewers:
f(malita), reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of SkImage-backed SkPictureShader (patchset #4 id:60001 of https://codereview.chromium.org/1343153003/ ) Reason for revert: This CL appears to be breaking the pictureshader, pictureshadertile and tiled_picture_shader GMs on the iPad4 and the N7. The artifact is black rectangles. Original issue's description: > SkImage-backed SkPictureShader > > Instead of using an explicit image generator + SkBitmap + bitmap shader, > switch to the shiny new SkImage/image generator/image shader. > > R=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/97be9a0c86eedd8ab85ae7d9aaccb0b0a8e4577d TBR=reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/25a5b0dd0c9e94d508b8a9f4de1f977e63775bd1

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -17 lines)			Patch
	M	src/core/SkPictureShader.cpp	View		2 chunks	+11 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374763003/1

5 years, 2 months ago (2015-09-28 16:32:45 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-09-28 16:33:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/25a5b0dd0c9e94d508b8a9f4de1f977e63775bd1

Expand Messages | Collapse Messages