Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1374653002: Enable errorprone on the chromium.fyi Errorprone Builder (Reland). (Closed)

Created:
5 years, 2 months ago by mikecase (-- gone --)
Modified:
5 years, 2 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable errorprone on the chromium.fyi Errorprone Builder (Reland). Enabling errorprone first on the fyi builder to test if things work. If everything seems ok, I will make enable_errorprone=1 the default. Original CL: https://codereview.chromium.org/1305303002/ BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_android/chromium_config.py View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mikecase (-- gone --)
Relanding enabling errorprone on fyi builder. This CL should have fixed the error that occurred ...
5 years, 2 months ago (2015-09-28 09:24:34 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 2 months ago (2015-09-28 09:46:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374653002/1
5 years, 2 months ago (2015-09-28 10:17:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296897
5 years, 2 months ago (2015-09-28 10:19:49 UTC) #6
mikecase (-- gone --)
5 years, 2 months ago (2015-09-28 10:48:19 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1371973002/ by mikecase@chromium.org.

The reason for reverting is: Errorprone still has problems running on the bots 
:-/

http://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%....

Powered by Google App Engine
This is Rietveld 408576698