Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1354783003: Update errorprone to 2.0.5 and make it work with jdk7 and 8. (Closed)

Created:
5 years, 3 months ago by mikecase (-- gone --)
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update errorprone to 2.0.5 and make it work with jdk7 and 8. The bots have jdk7 and dev machines have jdk8. One of the jars in jdk is a dependency for errorprone. Older versions require don't work with jdk8 and newer versions require jdk8. To get around this, I am updating errorprone to the latest release and also just adding the required jar, javac-1.9.0-dev-r2644-1.jar, to the errorprone/lib/ folder. BUG= Committed: https://crrev.com/bf3dc38d551c62f884eaaed5452fb3a94a4f25f9 Cr-Commit-Position: refs/heads/master@{#350881}

Patch Set 1 #

Patch Set 2 : Update README.chromium in errorprone/lib and DEPS in this CL. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/errorprone/BUILD.gn View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/errorprone/README.chromium View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/errorprone/errorprone.gyp View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mikecase (-- gone --)
5 years, 3 months ago (2015-09-18 01:54:41 UTC) #2
mikecase (-- gone --)
pinging this CL. If you're OK with adding in the javac (https://github.com/google/error-prone-javac) that errorprone needs ...
5 years, 3 months ago (2015-09-22 21:26:14 UTC) #3
mikecase (-- gone --)
Updated the README.chromium in the errorprone git repo. Updated the README.chromium in chromium to match, ...
5 years, 3 months ago (2015-09-23 00:04:20 UTC) #4
jbudorick
lgtm
5 years, 2 months ago (2015-09-24 23:46:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354783003/20001
5 years, 2 months ago (2015-09-25 17:53:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354783003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354783003/40001
5 years, 2 months ago (2015-09-25 18:12:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-25 19:19:53 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 19:22:39 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf3dc38d551c62f884eaaed5452fb3a94a4f25f9
Cr-Commit-Position: refs/heads/master@{#350881}

Powered by Google App Engine
This is Rietveld 408576698