Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2222)

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 137463002: RenderFrame: flesh out Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Remove obsolete WebFrame parameter Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/render_frame_observer.h
diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h
index e2b27f4099160e630a1c721aad4200eac4963e61..93a83ac236663cfef9b4dff098210aa09ecb0c73 100644
--- a/content/public/renderer/render_frame_observer.h
+++ b/content/public/renderer/render_frame_observer.h
@@ -13,6 +13,7 @@
namespace blink {
class WebFrame;
+class WebURLError;
}
namespace content {
@@ -34,8 +35,10 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
// These match the Blink API notifications
- virtual void DidCommitProvisionalLoad(blink::WebFrame* frame,
- bool is_new_navigation) {}
+ virtual void DidCommitProvisionalLoad(bool is_new_navigation) {}
+ virtual void DidStartProvisionalLoad() { }
jam 2014/01/22 03:15:35 nit: no space inside brackets, also below
+ virtual void DidFailProvisionalLoad(const blink::WebURLError& error) { }
+ virtual void DidFinishLoad() { }
// IPC::Listener implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698