Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 137463002: RenderFrame: flesh out Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Remove obsolete WebFrame parameter Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 631a86edb626f376a1c1f9257c1d5d4e5e6d6867..d8cf16d67f67a4b59c1aad21818fa75923fc1ef1 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -800,6 +800,10 @@ void RenderFrameImpl::didStartProvisionalLoad(blink::WebFrame* frame) {
RenderViewObserver, render_view_->observers(),
DidStartProvisionalLoad(frame));
+ FOR_EACH_OBSERVER(
+ RenderFrameObserver, observers_,
+ DidStartProvisionalLoad());
+
Send(new FrameHostMsg_DidStartProvisionalLoadForFrame(
routing_id_, frame->identifier(),
frame->parent() ? frame->parent()->identifier() : -1,
@@ -839,6 +843,9 @@ void RenderFrameImpl::didFailProvisionalLoad(
// Call out to RenderViewImpl, so observers are notified.
render_view_->didFailProvisionalLoad(frame, error);
+ FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
+ DidFailProvisionalLoad(error));
+
bool show_repost_interstitial =
(error.reason == net::ERR_CACHE_MISS &&
EqualsASCII(failed_request.httpMethod(), "POST"));
@@ -941,7 +948,7 @@ void RenderFrameImpl::didCommitProvisionalLoad(blink::WebFrame* frame,
render_view_->didCommitProvisionalLoad(frame, is_new_navigation);
FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
- DidCommitProvisionalLoad(frame, is_new_navigation));
+ DidCommitProvisionalLoad(is_new_navigation));
}
void RenderFrameImpl::didClearWindowObject(blink::WebFrame* frame,
@@ -1004,6 +1011,8 @@ void RenderFrameImpl::didFailLoad(blink::WebFrame* frame,
void RenderFrameImpl::didFinishLoad(blink::WebFrame* frame) {
// TODO(nasko): Move implementation here. No state needed, just observers
// notification before sending message to the browser process.
+ FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
+ DidFinishLoad());
render_view_->didFinishLoad(frame);
}

Powered by Google App Engine
This is Rietveld 408576698