RenderFrame: flesh out Observer

content/public/renderer/render_frame_observer.h

Index: content/public/renderer/render_frame_observer.h
diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h
index e2b27f4099160e630a1c721aad4200eac4963e61..651722641b0bae6cf05427eb71d36b6740ece843 100644
--- a/content/public/renderer/render_frame_observer.h
+++ b/content/public/renderer/render_frame_observer.h
@@ -12,7 +12,9 @@
 #include "ipc/ipc_sender.h"
 
 namespace blink {
+class WebDataSource;
 class WebFrame;
+class WebURLError;
 }
 
 namespace content {
@@ -34,8 +36,14 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
   virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
 
   // These match the Blink API notifications
+  virtual void DidCreateDataSource(blink::WebFrame* frame,

[jam, 2014/01/16 22:17:08]

i don't see this being used in the new helper? let's leave it out until we have
a use case for it

+                                   blink::WebDataSource* data_source) { }
   virtual void DidCommitProvisionalLoad(blink::WebFrame* frame,
                                         bool is_new_navigation) {}
+  virtual void DidStartProvisionalLoad(blink::WebFrame* frame) { }

[jam, 2014/01/16 22:17:08]

in the new methods, can you remove the blink::WebFrame? that is now redundant
since there's one WebFrame per RenderFrame

+  virtual void DidFailProvisionalLoad(blink::WebFrame* frame,

[jam, 2014/01/16 22:17:08]

ditto

+                                      const blink::WebURLError& error) { }
+  virtual void DidFinishLoad(blink::WebFrame* frame) { }
 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;