RenderFrame: flesh out Observer

content/public/renderer/render_frame_observer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
 #include "ipc/ipc_listener.h"
 #include "ipc/ipc_sender.h"
 
 namespace blink {
+class WebDataSource;
 class WebFrame;
+class WebURLError;
 }
 
 namespace content {
 
 class RendererPpapiHost;
 class RenderFrame;
 class RenderFrameImpl;
 
 // Base class for objects that want to filter incoming IPCs, and also get
 // notified of changes to the frame.
 class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
                                            public IPC::Sender {
  public:
   // By default, observers will be deleted when the RenderFrame goes away.  If
   // they want to outlive it, they can override this function.
   virtual void OnDestruct();
 
   // Called when a Pepper plugin is created.
   virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
 
   // These match the Blink API notifications
+  virtual void DidCreateDataSource(blink::WebFrame* frame,

[jam, 2014/01/16 22:17:08]

i don't see this being used in the new helper? let's leave it out until we have
a use case for it

+                                   blink::WebDataSource* data_source) { }
   virtual void DidCommitProvisionalLoad(blink::WebFrame* frame,
                                         bool is_new_navigation) {}
+  virtual void DidStartProvisionalLoad(blink::WebFrame* frame) { }

[jam, 2014/01/16 22:17:08]

in the new methods, can you remove the blink::WebFrame? that is now redundant
since there's one WebFrame per RenderFrame

+  virtual void DidFailProvisionalLoad(blink::WebFrame* frame,

[jam, 2014/01/16 22:17:08]

ditto

+                                      const blink::WebURLError& error) { }
+  virtual void DidFinishLoad(blink::WebFrame* frame) { }
 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // IPC::Sender implementation.
   virtual bool Send(IPC::Message* message) OVERRIDE;
 
   RenderFrame* render_frame() const;
   int routing_id() const { return routing_id_; }
 
@@ skipping 11 matching lines @@
   RenderFrame* render_frame_;
   // The routing ID of the associated RenderFrame.
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_