Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1374563002: Revert of Upgrading binutils to 2.25 for -ggnu-pubnames (Closed)

Created:
5 years, 2 months ago by ukai
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang, Nico, mithro-old
CC:
chromium-reviews, Jeffrey Yasskin, awong
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upgrading binutils to 2.25 for -ggnu-pubnames (patchset #2 id:20001 of https://codereview.chromium.org/1368233002/ ) Reason for revert: binutils is not deployed in goma backend, and this roll causes slow compile on linux BUG=536663 Original issue's description: > Upgrading binutils to 2.25 for -ggnu-pubnames > > To make static_library builds fast we need binutils 2.25 to enable > -ggnu-pubnames support. > > The ehframe-race.patch is removed because it is now included upstream. Dates > and expected release versions have been added for the remaining patches to make > it easier to upgrade in the future. > > (Also use a precise chroot rather than lucid for building binutils.) > > BUG=374952 > > Committed: https://crrev.com/1a4e8c12aa264a54432b38fa009b0aa4814caea1 > Cr-Commit-Position: refs/heads/master@{#351019} TBR=thestig@chromium.org,thakis@chromium.org,mithro@mithis.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=374952 Committed: https://crrev.com/1279f1717697850ff5d3ba5206551610ec990e1c Cr-Commit-Position: refs/heads/master@{#351027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -22 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/binutils/build-all.sh View 4 chunks +6 lines, -13 lines 0 comments Download
A third_party/binutils/ehframe-race.patch View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ukai
Created Revert of Upgrading binutils to 2.25 for -ggnu-pubnames
5 years, 2 months ago (2015-09-28 06:42:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374563002/1
5 years, 2 months ago (2015-09-28 06:42:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 06:43:52 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 06:44:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1279f1717697850ff5d3ba5206551610ec990e1c
Cr-Commit-Position: refs/heads/master@{#351027}

Powered by Google App Engine
This is Rietveld 408576698