Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1368233002: Upgrading binutils to 2.25 for -ggnu-pubnames (Closed)

Created:
5 years, 2 months ago by mithro-old
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, Jeffrey Yasskin, awong
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upgrading binutils to 2.25 for -ggnu-pubnames To make static_library builds fast we need binutils 2.25 to enable -ggnu-pubnames support. The ehframe-race.patch is removed because it is now included upstream. Dates and expected release versions have been added for the remaining patches to make it easier to upgrade in the future. (Also use a precise chroot rather than lucid for building binutils.) BUG=374952 Committed: https://crrev.com/1a4e8c12aa264a54432b38fa009b0aa4814caea1 Cr-Commit-Position: refs/heads/master@{#351019} Committed: https://crrev.com/c46156fa7b05d0cf3cb1f317e092310e155ed3ad Cr-Commit-Position: refs/heads/master@{#351682}

Patch Set 1 #

Patch Set 2 : Adding the sha1 commits. #

Patch Set 3 : Adding upgrade instructions about goma. See http://crbug.com/536663 #

Patch Set 4 : Small wording fix. #

Patch Set 5 : Extra details about goma. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -111 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 1 2 3 4 2 chunks +24 lines, -6 lines 0 comments Download
M third_party/binutils/build-all.sh View 4 chunks +13 lines, -6 lines 0 comments Download
D third_party/binutils/ehframe-race.patch View 1 chunk +0 lines, -96 lines 0 comments Download
M third_party/binutils/upload.sh View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
mithro-old
Hi, I'm upgrading binutils as required by http://crbug.com/374952 My build scripts made it pretty easy ...
5 years, 2 months ago (2015-09-27 13:01:08 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-09-28 02:35:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368233002/20001
5 years, 2 months ago (2015-09-28 03:37:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 03:50:22 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1a4e8c12aa264a54432b38fa009b0aa4814caea1 Cr-Commit-Position: refs/heads/master@{#351019}
5 years, 2 months ago (2015-09-28 03:51:09 UTC) #7
ukai
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1374563002/ by ukai@chromium.org. ...
5 years, 2 months ago (2015-09-28 06:41:59 UTC) #8
mithro-old
Just a FYI for everyone. I'm submitting this patch again now after it has been ...
5 years, 2 months ago (2015-09-30 23:59:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368233002/80001
5 years, 2 months ago (2015-10-01 00:00:10 UTC) #12
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-01 00:01:16 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-01 00:19:25 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 00:20:26 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c46156fa7b05d0cf3cb1f317e092310e155ed3ad
Cr-Commit-Position: refs/heads/master@{#351682}

Powered by Google App Engine
This is Rietveld 408576698