Issue 1374493002: SkStream: don't segfault on empty asset getMemoryBase().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374493002: SkStream: don't segfault on empty asset getMemoryBase(). (Closed)

Created:
5 years, 2 months ago by hal.canary

Modified:
5 years, 2 months ago

Reviewers:
bungeman-skia, halcanary_use_other_email

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

SkBlockMemoryStream: correct test in getMemoryBase(). The test "nullptr == fBlockMemory->fHead->fNext" tests that all of the data is in one block, but it is also necessary to test "fBlockMemory->fHead" to ensure that there is a first block with data in it. Committed: https://skia.googlesource.com/skia/+/209c1624addaa7f7e63b79d286bd350342740a00

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/core/SkStream.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tests/StreamTest.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374493002/1

5 years, 2 months ago (2015-09-28 14:23:21 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-09-28 14:29:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/209c1624addaa7f7e63b79d286bd350342740a00

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages