src/core/SkStream.cpp - Issue 1374493002: SkStream: don't segfault on empty asset getMemoryBase().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkStream.cpp

Issue 1374493002: SkStream: don't segfault on empty asset getMemoryBase(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkStream.cpp

diff --git a/src/core/SkStream.cpp b/src/core/SkStream.cpp

index 5a66399f5e38a1e1d73b731f7ef1da3747314364..b834513b4f638477c803d5083e1ac4d441f6f9c7 100644

--- a/src/core/SkStream.cpp

+++ b/src/core/SkStream.cpp

@@ -795,7 +795,8 @@ public:

}

const void* getMemoryBase() override {

- if (nullptr == fBlockMemory->fHead->fNext) {

+ if (nullptr != fBlockMemory->fHead &&

+ nullptr == fBlockMemory->fHead->fNext) {

return fBlockMemory->fHead->start();

}

return nullptr;

« no previous file with comments | « no previous file | tests/StreamTest.cpp » ('j') | no next file with comments »