Issue 137443024: Hook up gomadir in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137443024: Hook up gomadir in the GN build. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Hook up gomadir in the GN build. Without this, GYP will fail if you manually specify gomadir in your GYP_DEFINES. R=jamesr@chromium.org, jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245595

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	build/gyp_chromium	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

brettw

Committed patchset #1 manually as r245595 (presubmit successful).

6 years, 11 months ago (2014-01-17 20:20:32 UTC) #3

sharpaquos1974

On 2014/01/17 20:20:32, brettw wrote: > Committed patchset #1 manually as r245595 (presubmit successful).

6 years, 11 months ago (2014-01-18 09:08:58 UTC) #4

sharpaquos1974

6 years, 11 months ago (2014-01-18 09:10:03 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/136473017/ by sharpaquos1974@gmail.com.

The reason for reverting is: login.