Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: build/gyp_chromium

Issue 137443024: Hook up gomadir in the GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index c67a985817d93a9bf6f5c04351a0ac868b03197f..f8fa93664642b73b23e673a31e8225c235e0dc1d 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -203,6 +203,10 @@ def GetArgsStringForGN(supplemental_files):
if v in vars_dict:
gn_args += ' ' + v + '=' + EscapeStringForGN(vars_dict[v])
+ # gomadir is renamed goma_dir in the GN build.
+ if 'gomadir' in vars_dict:
+ gn_args += ' goma_dir="%s"' % vars_dict['gomadir']
+
# These arguments get passed directly as integers (avoiding the quoting and
# escaping of the string ones above).
for v in ['arm_version']:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698