src/x64/debug-x64.cc - Issue 137443004: Use kRegisterSize when passing arguments to the C++ runtime for X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/debug-x64.cc

Issue 137443004: Use kRegisterSize when passing arguments to the C++ runtime for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comment Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/debug-x64.cc

diff --git a/src/x64/debug-x64.cc b/src/x64/debug-x64.cc

index 5ddf69a414e410d79951c353b0a32589b18fe861..4be215dd17158754e7b3b8563a380387c7485dc8 100644

--- a/src/x64/debug-x64.cc

+++ b/src/x64/debug-x64.cc

@@ -164,7 +164,7 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

// If this call did not replace a call but patched other code then there will

// be an unwanted return address left on the stack. Here we get rid of that.

if (convert_call_to_jmp) {

- __ addq(rsp, Immediate(kPointerSize));

+ __ addq(rsp, Immediate(kPCOnStackSize));

}

// Now that the break point has been handled, resume normal execution by

« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »